You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(create-react-native-library): fix npm install and missing lint dependencies - #956
Fixes ERESOLVE peer dependency issues with prettier by using ^3.0.0, and adds missing eslint-plugin-react-native dependency along with correct version for eslint-plugin-prettier as reported in issue #919.
Why
This change resolves the target issue or improvement.
How to test
Verify that the project builds/runs correctly and the specific bug/improvement is addressed.
Thanks for the PR. The template was already updated to use prettier v3 in #930, and the fix is out in create-react-native-library@0.58.0. So the ERESOLVE error from #919 doesn't happen with the latest version.
eslint-plugin-react-native doesn't need to be added either. It's a dependency of @react-native/eslint-config, and npm hoists it to the top-level node_modules, so ESLint can find it. Installing the template's dependencies with npm and running eslint with the template's config works without errors.
The remaining changes lower the minimum versions of prettier and eslint-plugin-prettier, which goes against the regular dependency upgrades in the template. So closing this. If you still see the error with the latest version, please open a new issue with the steps to reproduce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes ERESOLVE peer dependency issues with prettier by using ^3.0.0, and adds missing eslint-plugin-react-native dependency along with correct version for eslint-plugin-prettier as reported in issue #919.
Why
This change resolves the target issue or improvement.
How to test
Verify that the project builds/runs correctly and the specific bug/improvement is addressed.
Fixes #919